FavIcon icon indicating copy to clipboard operation
FavIcon copied to clipboard

Make sortIcons function public?

Open Vortec4800 opened this issue 4 years ago • 2 comments

Would you consider making the sortIcons function public so it can be accessed outside the library? I'd like to use the equivalent functionality to the downloadPreferred function, but I only want to store the icon URLs and leave actual image loading to another area in the app. If the sortIcons func were available, I could use the scan function to get all the Icons, then sort them by my desired size and finally grab the topmost icon and store that URL.

If I sent in a PR with that change, would you merge it?

Vortec4800 avatar Aug 12 '20 19:08 Vortec4800

Sounds like a reasonable request, send the PR through!

leonbreedt avatar Aug 13 '20 00:08 leonbreedt

@Vortec4800 i am no longer able to work much on this library. you may want to consider an alternative such as https://github.com/will-lumley/FaviconFinder

leonbreedt avatar May 13 '21 21:05 leonbreedt