tabr icon indicating copy to clipboard operation
tabr copied to clipboard

*Error: Explicit fret range will cut off notes.* when using "fret_range" parameter, function plot_fretboard

Open AHMcKenzie opened this issue 1 year ago • 0 comments

Hello Matt,

Thanks for adding fret labels/numbers on the recent 0.5.0 update. I tried the new "fret_label" parameter but I'm getting this error message:

Error: Explicit fret range will cut off notes.

I'm using the "fret_range" clause on my scripts, they worked well before. When used with your sample plot_fretboard() call, I get the same error message. This is the test line:

plot_fretboard (string, fret, "notes", show_tuning = TRUE, fret_labels = c(3, 5, 7, 9, 12), fret_range = c(4, 10))

I was able to circumvent the error by excluding a condition test you have in function plot_fretboard, around lines 148-151 in file "plot.R". This function has changed considerably so I don't know what other effects my change will introduce, but per your documentation "fret_range" should be able to constrain the fretboard range being rendered, and it is not.

Please advice, thanks, Alex

AHMcKenzie avatar Jul 04 '24 18:07 AHMcKenzie