Leonardus Chen

Results 23 comments of Leonardus Chen

How's the refactoring going? If you're short on time and if it is at a state where you can offload some work, I'd be happy to help out

Thanks for the updates!

I think we can skip calling `get_adapted_type` altogether and just use whatever datatype `MetaData.reflect` gives us. The reflection gives the most specific datatype by default. From [docs](https://docs.sqlalchemy.org/en/14/core/reflection.html#reflecting-with-database-agnostic-types): >When the columns...

Hello, I'd like to give this a go. I'll dig into this and see if I can come up with a quick workaround. While I'm at it, I'll also think...

This isn't implemented yet in `master`, is a PR still welome?

I think this should do the job (must be placed above the overload for `Callable[..., T]`) ```python class Resource(Provider[T]): . . . @overload def __init__( self, provides: Optional[_Callable[..., contextlib.AbstractContextManager[T]]] =...

Right, I noticed the issue when working on the Selector typevar, I thought I'd open a new issue to discuss first to make sure I understand the problem correctly :)...

@ZipFile I'll split the rest of the work over a few PRs if that's ok. I'm thinking do the retrofit for the rest of providers stub tests before continuing #930