New button configuration not recognized by vscode

[atakiya]

I've left a comment on the original PR introducing this feature, but here's an issue just for organization's sake.

About

The configuration entry for vscord.status.buttons introduced by #183 (d689dfb35d5fb180d53ebfe2cfe7d64701d1ef1f) is not recognized by vscode, despite working as intended.

See linked image below

Possibly caused by 817fa07b2af07d3d49cb0989727268192f69e686

[xhayper]

The reason why i switch over to the one in 817fa07 is because we benefit from json schema which will validate user input, in reality, both should work except the .buttons": {} have no safety.

[atakiya]

The reason why i switch over to the one in 817fa07 is because we benefit from json schema which will validate user input, in reality, both should work except the .buttons": {} have no safety.

Theoretically you should be able to add type checking for the buttons objects as well, without impeding the other one. But I do must admit that I haven't worked with vscode extension development yet, this is pure speculation on my part. I might look into it when i got some time myself - if you got no plans to fix this, then feel free to close.

[xhayper]

I might actually look into this, but the first time we did it, it kinda didn't type check for us, sadly.

[atakiya]

I've got it working in #196 - it really just needed a proper JSON-schema-like definition to be made. See the PR for a couple problems I think that might crop up - its nothing code-breaking, but more a general maintenance and usability worry of my own opinion.