Zhao Changmin

Results 46 comments of Zhao Changmin

> Do we have type checking tests for orca? I had enable mypy for type checking on orca, but actually it seems not that useful on orca, for there are...

> Is it possible to first enable the type checking in `orca.data`. Otherwise it is hard to verify the changes are correct. Sure, I will try this in `orca.data`.

> https://github.com/intel-analytics/BigDL/blob/main/python/orca/src/bigdl/orca/data/elastic_search.py is missing, is it needed? I think it is for internal use.

> Do we have any mechanism to make sure if future functions are added in orca/data they are always typed? 1, we can enable strict mode in mypy to force...

Actually, when testing my code followed: ``` # from petastorm.codecs import CompressedImageCodec, NdarrayCodec, ScalarCodec # from petastorm.etl.dataset_metadata import materialize_dataset # from petastorm.unischema import Unischema, UnischemaField, dict_to_spark_row from pyspark.sql import SparkSession...

So maybe import petastorm change the behavior of pyspark?

Yes, by adjusting the import position of petastorm and pyspark solves this problem, thanks a lot!

hi @tsantra , I am sorry that I can not reproduce this issue on MTL linux igpu. **BTW, You say you are using an ARC GPU, you mean MTL igpu(also...

> Hi @leonardozcm, I will try to reproduce the issue and get back to you. Thanks a lot

@WeiguangHan hi, could you please take a look at this?