dotnet-affected icon indicating copy to clipboard operation
dotnet-affected copied to clipboard

Add support for package version override in detecting changes in NuGet versions

Open wterpstra opened this issue 2 years ago • 2 comments

Minor issue, it might mark projects as affected when they are not necessarily.

NuGet 6.2 introduces central package management and drops the preview flag. However they also support overriding individual packages on individual projects. When overridden we should not mark those projects affected when the centrally managed version changes.

https://devblogs.microsoft.com/nuget/introducing-central-package-management/

wterpstra avatar Apr 13 '22 21:04 wterpstra

Hi @wterpstra ! Nice to see it out of preview.

Do you wanna give this a go?

leonardochaia avatar Apr 19 '22 11:04 leonardochaia

To add on to this:

What this means is that if you had multiple Directory.Packages.props files in your repository, the file that is closest to your project’s directory will be evaluated for it. This allows you extra control at various levels of your repository.

There are properties in the MSBuild Projects that tells us the location of the Directory.Package.props file being used. We need to refactor and use that to determine which file to consider for each project.

leonardochaia avatar Jul 18 '22 15:07 leonardochaia