Leonard Brünings

Results 271 comments of Leonard Brünings

Hi, spock has no logging library at the moment, this is not an accident. Furthermore, you already get the error as the cause of the SpockException so I don't see...

Hm, having something akin to https://github.com/spockframework/spock/blob/d751a0abd8d5a2ec5338aa10bc2d19371b3b3ad9/spock-core/src/main/java/spock/lang/Retry.java#L47-L54 as property for `PollingConditions` would be ok. Please be aware, that we won't merge anything until 2.0 branch is green.

Yes, this is problem with the way `@SpringBeans` work, i.e. you actually have two mocks, one in the Spring Context and the other you create in the Specification. The mock...

I was wondering, shouldn't the line `.transform(Transformer.ForMethod.withModifiers(SynchronizationState.PLAIN, Visibility.PUBLIC))` (org/spockframework/mock/runtime/ByteBuddyMockFactory.java:66) overwrite every method as public?

Hi, thanks for the initiative, but I don't think that this is the right approach. As effect is global it will switch the behavior for all mocks, which will be...

First, this is how spock defines the terms: * [stubbing](http://spockframework.org/spock/docs/1.3/all_in_one.html#_stubbing): Stubbing is the act of making collaborators respond to method calls in a certain way. When stubbing a method, you...

> Thanks for your elaboration and sorry for using the wrong terms. I will try to use the correct ones in the future. It was not intended as a rebuke,...

We could open a new interaction scope at the start of the method, this way you could define some stubbing in the `given` that should override the one from the...

> but it does not solve the request to be able to override everywhere. @BoukeNijhuis could you give more examples of where you'd actually like to override this, that couldn't...

I checked the code and the `org.spockframework.mock.IMockFactory` interface already has a `canCreate(IMockConfiguration configuration)` method. The `CompositeMockFactory` would just have to use the `ServiceLoader` api to load any `IMockFactory` and put...