leon icon indicating copy to clipboard operation
leon copied to clipboard

Forecast/weather package

Open Thibaud-A opened this issue 6 years ago • 11 comments

Feature Use Case

Give informations about weather

  • Input : a date(today(default), tomorrow), a city name(external ip geolocalisation(default))
  • Output : weather, temperature and if the weather will remain stable in a few hour
# Example
--> Leon, how's the weather ?
<-- I'm searching weather for Rouen
    Today, clear sky, the temperature at Rouen 18°C
    Weather will remain stable

Feature Proposal

Implement a weather package which give information about the weather using external API like openweathermap. We can also use external IP geolocalisation, like that we can avoid asking the localisation.

Thibaud-A avatar Feb 26 '19 13:02 Thibaud-A

Hello @Thibaud-A,

Thanks for your suggestion. Better to wait for the NLU improvement before creating this module.

I added it to the roadmap 😉

louistiti avatar Feb 27 '19 04:02 louistiti

Hello @louistiti ,

Ok thanks ! I already did a little POC using openweathermap for the weather forecast and ipstack for the ip geolocalisation. If someone have better API don't hesitate to suggest me. In any case, I'll wait the NLU improvement before converting this POC in a real package.

Thibaud-A avatar Feb 27 '19 05:02 Thibaud-A

Awesome!

I'm looking forward to see your contribution later on then 👍

louistiti avatar Feb 27 '19 05:02 louistiti

I can write something for this Sunday using the Dark Sky API; the pricing plan seems to be a lot cheaper than openweathermap (the first 1000 api calls are free and $0.0001 / call after that).

ethinallen avatar Mar 01 '19 16:03 ethinallen

Hello @ethinallen,

Great! We could definitely create a Forecast package which contains the OpenWeatherMap and the Dark Sky modules.

However, to make Leon understands which one of these modules he needs to use we'll need to add using dark sky or using openweathermap to the expressions for one of these modules. So we'll need to see which one we can use as default module as the expressions will be pretty much the same.

Also, please note that the NLU needs to be improved before starting working on this package.

louistiti avatar Mar 02 '19 01:03 louistiti

Hello @ethinallen,

Thanks for your suggestion ! :-) I checked the pros and the cons between OpenWeatherMap and Dark Sky and I have concluded this.

Pro of Darsky :

  • more precise when you want minute to minute weather

Cons :

  • less features on the free version,
  • less call availables (1000 per day for Dark Sky and 60 per minutes/86400 per day for OpenWeatherMap)
  • only one way to give information on the location (longitude/lattitude). In OpenWeatherMap you can :
    • by city name
    • by city ID
    • by long/lat
    • by zip code
  • you can ask for several cities in a single request
  • uv index feature for free (I don't know that could exist)

In any case, as @louistiti said it could be great to give the opportunity to use differents API. I suggest OpenWeatherMap because there is a lot of features free and you don't have to set a credit card for using it. But if you want to lay the foundation of this package with Dark Sky : go for it ! :D

Thibaud-A avatar Mar 02 '19 10:03 Thibaud-A

For simple use there's https://wttr.in

Immortalin avatar Apr 25 '19 15:04 Immortalin

Hello @Immortalin,

Thanks for sharing! It seems to use wego for the data sources, which means it is using OpenWeatherMap, etc. Better to directly pull data from the sources instead of having another layer between.

louistiti avatar Apr 26 '19 00:04 louistiti

Hi @louistiti , was playing around with Leon and found it fascinating! Though I noticed too that there was no weather module, similarly to what was described in issue #251 . Could I check if a quick POC can be done on this or it should wait for other improvements? Thanks!

jaabberwocky avatar Aug 29 '21 04:08 jaabberwocky

Hi @jaabberwocky :wave:,

Thanks for willing to contribute into Leon! At this stage I'd say it'd be better to wait for upcoming versions but feel free to contribute. All the PRs will be merged once some upcoming versions will be released.

louistiti avatar Sep 04 '21 03:09 louistiti