Leo Lara

Results 108 comments of Leo Lara

> The lookup table also needs to contain the empty bytecode. The empty bytecode has a code_hash but has no bytes. How would you represent it? If you represent it...

So, after thinking about this, I think adding the tag Length row and tag collumn solves many problems. Another thing that came up for me is that we are in...

@ed255 Another idea for optimisation: the value column currently can only be 0..255, what if we use other values to mean other things. For example 256 could mean that this...

@ed255 @han0110 if the first value_rlc is 0 `assert next.value_rlc == 0` and then each row includes the previous row value: `assert next.value_rlc == curr.value_rlc * randomness + curr.value` It...

Draft uploaded https://github.com/privacy-scaling-explorations/zkevm-specs/pull/340

PR ready for review: https://github.com/privacy-scaling-explorations/zkevm-specs/pull/340

@pinkiebell @AronisAt79 can I help with this while I learn more about the project in general?

@han0110 @ChengYueJia Doesn't SuperCircuit get used outside the tests to run the actual system?

But then, my question is SuperCircuit uses the Circuit implementation of the other SubCircuits: https://github.com/privacy-scaling-explorations/zkevm-circuits/blob/main/zkevm-circuits/src/super_circuit.rs#L269-L276 so all these, should not be only in the tests, but also in production, right?