cz-customizable icon indicating copy to clipboard operation
cz-customizable copied to clipboard

Published 20 hours ago • verified publisher icon leoforfree

fix: add option usePreparedCommit default false

Open leonardoanalista opened this issue 3 years ago • 2 comments

fix: add option usePreparedCommit default false

TODO: it needs unit tests for coverage

ISSUES CLOSED: #173

leonardoanalista avatar Jul 02 '22 13:07 leonardoanalista

Can we have this PR merged please

It's just pending unit test coverage. Also considering making this a breaking change since the default is now "false" for usePreparedCommit. Before it was kind of "true".

I am away this week. I'll be able to write the tests mid-next week.

leonardoanalista avatar Aug 02 '22 03:08 leonardoanalista

Sounds good!, thanks man

jainanuj0812 avatar Aug 02 '22 06:08 jainanuj0812

This issue has been bothering me, I hope this PR can be merged in time.

HandlesBuilder avatar Sep 01 '22 05:09 HandlesBuilder

@docker-soga I'll try to address the code coverage today so we can merge it.

I think this is a breaking change as it changes the default option.

leonardoanalista avatar Sep 02 '22 01:09 leonardoanalista

I am really thinking if we need this option usePreparedCommit. I am not sure if people out there use it. We should to deprecate it.

leonardoanalista avatar Sep 02 '22 02:09 leonardoanalista