Leo Fang

Results 1175 comments of Leo Fang

Thanks for help, Bernhard!

Thanks, @bernhardmgruber! Appreciate for the help! > I could not figure out how to run the unit tests covering the C++ part from your [documentation](https://docs.cupy.dev/en/stable/contribution.html#how-to-run-tests). `pip install -e .` ran...

btw @takagi plz merge this PR after #8412 is merged, which would bring us much closer to why this PR is needed. Thanks 🙏

Sorry for my late reply, slowly catching up after returning from time-off... > I think the performance of FP sorting should be prioritized over working with NaNs "correctly" (aligning with...

That said, one questions I raised (internally) is still unresolved: That Thrust uses radix sort under the hood is an implementation detail as far as CuPy is concerned. How do...

> One thing was about `top_k` as a future function, which gives the K-largest or K-smallest values. xref: https://github.com/data-apis/array-api/pull/722 > I see three options: I think 3 (merging as-is) is...

Nontrivial mypy errors arose from @shwina investigation, from both 3rd and 1st party code. Pushing to beta 4.

Hmmm I would expect most of the CI to not run since only Python files are changed...

@gevtushenko I thought it's already merged but just realized it's not. Any concern for merging (once I resolve conflicts)?