Results 57 comments of Léo Lam

> The use of the destructor within Super Mario Odyssey suggests that it has been declared =default in the header, as the existing destructors never get called by any code....

> Sorry, I'm not fluent with all of the terminology. By explicit I meant that the function does exist in the list of functions and does have a symbol, not...

Leaflet appears to support fractional zoom levels: https://leafletjs.com/examples/zoom-levels/ Not sure how well this works for BotW's map tiles, though.

> Another option would be to add it under the Search pane but like the Help pane with the list of Korok Types. Sounds good. Alternatively, we can keep it...

The strings are [dynamically generated in the function that loads info from bdrop files](https://f.leolam.fr/load_bdrop_params.html), so the entire string cannot be directly found in the executable (and thus your crc hashmap...

Apologies for the delayed response. Could you rebase this on master (I believe the .row -> .shoprow thing has already been fixed), and add the script you used to generate...

The sead build issue has been fixed now. This should build fine after the PR is rebased on master.

Please fix these warnings: https://ci.botw.link/#/builders/3/builds/58 Feel free to ignore `constructor does not initialize these fields: mSingletonDisposerBuf_ [cppcoreguidelines-pro-type-member-init]` though

Can't reproduce your issue with Majora's Mask 1.0 and Project Restoration 1.5.9 (v100), even on a fresh save. ![mm3d_rst_issue_230_no_repro_1](https://user-images.githubusercontent.com/4209061/194715181-d5caedbb-78ae-4842-988a-c5ab022b40f4.png) ![mm3d_rst_issue_230_no_repro_2](https://user-images.githubusercontent.com/4209061/194715177-f8017a6b-fdb3-4ddd-a3a3-dbfde607371b.png) It looks like there's something seriously wrong with your game...

Type punning with unions is undefined behavior in C++.