angular-chosen icon indicating copy to clipboard operation
angular-chosen copied to clipboard

Automatically Deploy

Open leocaseiro opened this issue 8 years ago • 10 comments

  • [x] Create Gulp file
  • [x] Add .coffeelint
  • [x] Add .editorconfig
  • [x] Add .min.js compiled
  • [x] Rename from chosen.js to angular-chosen.js (perhaps)
  • [x] Add Unit Tests (specially for fix issues)
  • [x] Configure Travis with Github for new PR
  • [x] Generate documentation with Slate at docs branch
  • [ ] Use Conventional Changelog
  • [ ] Commit using commitizen
  • [ ] Write a CONTRIBUTING.md following angular-formly as reference

leocaseiro avatar Feb 29 '16 23:02 leocaseiro

Gulp Tasks

Main Tasks

  • build: Compile CoffeeScript and minify Javascript generated
  • watcher: Watch in real-time while Compile CoffeeScripts and minify Javascript generated

Sub Tasks

  • build-clean-javascripts: Clean ./dist/
  • build-coffee-script: Compile ./src/chosen.coffee into ./dist/angular-chosen.js
  • build-minify: Minify ./dist/angular-chosen.js into ./dist/angular-chosen.min.js

leocaseiro avatar Mar 01 '16 10:03 leocaseiro

Documentation is at docs branch and probably will remain there.

We are using Slate Edit using markdown /docs/source/index.html.md or /docs/source/includes/_examples.html.md

To deploy docs, run:

./deploy.sh 

leocaseiro avatar Mar 08 '16 20:03 leocaseiro

Recommend to also add http://editorconfig.org/ file alongside with jshint.

Tho suppose you need coffeelint instead?

simison avatar Mar 11 '16 10:03 simison

BTW Bower recommends not to add minified files: https://github.com/bower/spec/blob/master/json.md

Do not include minified files.

simison avatar Mar 11 '16 10:03 simison

Hi, I'm using angular chosen in my project, problem is after gulp build chosen icons are missing, please advise me

image

xts-velkumars avatar Jun 21 '17 08:06 xts-velkumars

You should use browser’s “inspect element” to see where those images are attempted to load from and ensure you’ll put images into that place (or overwrite CSS for those parts to load images from somewhere else).

Hope this helps!

On 21 Jun 2017, at 11.04, velkumars [email protected] wrote:

Hi, I'm using angular chosen in my project, problem is after gulp build chosen icons are missing, please advise me

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

simison avatar Jun 21 '17 08:06 simison

@simison, i did that i can clearly see "chosen-sprite.png" not bundled it seems after my minification process

xts-velkumars avatar Jun 21 '17 09:06 xts-velkumars

Sorry but it’s impossible to help without knowing what you’re actually doing or without seeing any code. :-/

You’ll just have to figure out how in your script you can get those images in right place relative to your CSS. This totally depends on your stack and built script.

Good luck!

On 21 Jun 2017, at 12.04, velkumars [email protected] wrote:

@simison, i did that i can clearly see "chosen-sprite.png" not bundled it seems after my minification process

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

simison avatar Jun 21 '17 09:06 simison

@velkumars: I just realised this is under an issue on another topic (I didn't realise it via emails). It's not polite to go off topic, but to open new issues instead. Better even use Stackoverflow since this isn't really a bug in library or anything like that.

simison avatar Jun 21 '17 10:06 simison

Hi @velkumars, this is not related to the Automatically Deploy, please, open your own issue. Also, I believe you haven't loaded properly your CSS from chosen library.

Thanks @simison

leocaseiro avatar Jun 21 '17 22:06 leocaseiro