Only one operation per file

[sebas5384]

Hi! this lib is so cool, thank you 👍

This lib supports one operation by file, but the graphql-tag/loader supports multiple.

Why do we have this limitation here?

I guess it could be useful to warn users about this limitation, since I got caught by surprise.

thanks!

[sebas5384]

Don't know if make sense but maybe It could modify the exported queries when there's multiple operations.

from:

module.exports = doc;
module.exports["MyQuery"] = oneQuery(doc, "MyQuery");
module.exports["MyMutation"] = oneQuery(doc, "MyMutation");

to:

module.exports = doc;
module.exports["MyQuery"] = oneQuery(doc, "MyQuery");
module.exports["MyMutation"] = oneQuery(doc, "MyMutation");
module.exports["MyQuery"].documentId = "HASH1";
module.exports["MyMutation"].documentId = "HASH2";

I guess the challenge here could be getting the operation name from the queryMap keys and then concatenate the module.exports["operationName"].documentId = "hash"; for each query at the end of the content.

[leoasis]

Hey! @sebas5384 I've been thinking about this, and based on the code I think we may need to do something different. In practice, you persist a document, not just a single query. In the case of a document with different operations, the documentId should still be the same, and you'd refer to the operation you want to execute with both the documentId and the operationName.

I think I'll be adding those changes, as right now PersistGraphQL splits the documents per operation and that's not what we really want to do. Also, PersistGraphQL will be deprecated, so we might just as well remove our dependency with it.

Any thoughts? Concerns? Anything you think I may be missing?

[leoasis]

Having said that, it seems that this is not really how the rest of the Apollo libraries work, as they all work with documents that contain a single operation, or split them into separate documents if that's the case. It feels now that maybe documentId is misleading in this case.

[sebas5384]

Hey @leoasis , yeah when I commit the code I thought about the documentId since is not the "document id" anymore is the "operation id". Maybe we could change that to operationId and get rid of the documentId.

About the PersistGraphQL being deprecated, are thinking on a new approach or something like that? or about these code:

const { ExtractGQL } = require('persistgraphql/lib/src/ExtractGQL');
const queryTransformers = require('persistgraphql/lib/src/queryTransformers');

if it is the code, then I guess we could open an issue as the https://github.com/apollographql/persistgraphql/pull/67 states, what do you think?

Sorry about the delay to answer you! I had to think for a while about my answer.