fvm
fvm copied to clipboard
leoafarias
Add flag to exit with error instead of asking for interaction
@Rexios80 is attempting to deploy a commit to the FlutterTools Team on Vercel.
A member of the Team first needs to authorize it.
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Rexios80 Shouldn't this return a selection or default selection instead of just exiting? Also, we have added an isCI flag. Would it be the same type of behavior to essentially skip selections in this case or select the default, and if no default is set, then exit?
The main user input I have issue with is the confirmation to install. The default value for that one is true which is not what I want. It also exits with a success exit code if you say no which is bad since it hides the issue from my tool. As for the selections, I don't see a way to do that without user interaction. The two selections I see (the one for selecting a flutter version and the one for fixing "invalid" flutter versions) both cannot be handled with a default. I mostly added the exit to the select call for consistency with the confirm call, so maybe we can remove that change?
The isCI flag looks promising, but this tool isn't only meant for use in CI so that seems a little weird.
I think I misread that you wanted to use the isCI flag for this. Yes this PR should be replicating the same behavior that we would expect in CI.
The force flag also skips interaction. Which command do you need this no interaction for?
Theoretically it could be any command that asks for interaction, but the biggest issue is when fvm asks to install a flutter version with fvm flutter ...
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| fvm | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 29, 2024 1:05pm |
@Rexios80 can you just update the docs on the website to document this flag?
@leoafarias Before I do that are we sure we like the flag name "--no-interact"? I didn't put much thought into it and I don't want us to be stuck with something we don't like forever.
Maybe "--no-input" would be better? Or even something like "--fvm-no-input" to guarantee it can't conflict with any dart/flutter flags?
@Rexios80 I will bring this in, but will change the default behavior to if isCI, to just use the default value on confirmation... and will define the default values for each.
@leoafarias I appreciate you merging this, but I would strongly prefer the default to be NOT installing a missing flutter version when --fvm-skip-input is passed. If a command is running headless, this will effectively freeze the command for up to several minutes.
I understand. As you can imagine, I am trying to minimize the flags and flows as much as possible.
What is the case where you run an fvm command that needs a version installed, but you don't want it to install?
The puby tool can run pub commands in mono-repos in parallel. If a project is set up with fvm, it will call fvm flutter commands. In the case that a user of puby calls puby {link, clean, etc} in an fvm project, but they do not have the required flutter version installed, the command will seem to hang for a long time. It also might try to install flutter many times at once which could cause issues. Since the commands are running in parallel, there is no good solution besides exiting. This could happen when another developer on the project updates the fvm flutter version, but other user's haven't installed it yet.
I don't see a use-case for --fvm-skip-input and auto-installing flutter versions. Scripts running in CI environments should be calling fvm install first anyways.