Lennart Jern

Results 67 comments of Lennart Jern

The current implementation is broken, yes. But we do need the functionality. How we did not notice that it was broken I cannot really tell though... this is unclear to...

I would expect that we can error out if any of the ValueSpecs clash with existing values. I will also try to clarify the exact use-case so that we could...

I want to fix it right away, if that's alright! I'll do a PR for gophercloud ASAP. From downstream I basically hear that we would need things to work the...

> Because of the large amount of code churn I have split the change into multiple commits. These commits each make a single refactor. I suggest that this PR will...

/test pull-cluster-api-provider-openstack-e2e-full-test

/test pull-cluster-api-provider-openstack-e2e-full-test

Replaced by #1516 which just drops `securityGroups` instead of renaming `securityGroupFilters` to `securityGroups` and dropping the old `securityGroups`.