Tomáš Glozar

Resolved (hopefully) all of the comments. There are some minor issues with the code like leftover declarations, I will clean it after rebasing to current master.

Just fixed a small readability issue (moving check for void return value to `ReturnPathAnalyser::visit(Subprog &subprog)`).

Rebased to solve merge conflicts. I also noticed another bug: `createRet` does not return here: ``` else if (inside_subprog_) { b_.CreateRetVoid(); } ``` causing segfault for void functions. I'll fix...

Fixed maps and casts in subprogs. Also added more tests to cover this functionality. Subprog argument implementation in codegen was changed to include ctx as the first argument, which is...

> Are there any outstanding work items left? Or are we missing a final round of reviews? > No, just waiting for reviews. > Side note, this behavior is a...

The PR should be now rebased and ready for merge.

The same issue also happens for the function call implementation in #3068, since the type of the function is not resolved yet in the first pass: ``` # bpftrace -e...

> 'newer' is 2017 right? Yes, I meant kernels release after merging the BPF subprog patch I linked. > I would like to see type signatures in the function. It...

> There's some documentation about bpf2bpf calls here: https://docs.cilium.io/en/stable/bpf/architecture/#bpf-to-bpf-calls . I think requiring bpf2bpf calls should be necessary. Inlining functions leads to way too much bloat and unpredictability. And bpf2bpf...

Now when the function definition support is implemented, the next logical step is to implement function call syntax. My original suggestion for the call syntax was this (updated to reflect...