axpbox icon indicating copy to clipboard operation
axpbox copied to clipboard

Arguments to serial console program don't allow spaces

Open lenticularis39 opened this issue 4 years ago • 6 comments

The command for the serial console program doesn't allow parameters with spaces (quotes don't work).

lenticularis39 avatar Sep 28 '20 14:09 lenticularis39

is this why I get a "Segmentation fault" when my command is action = "/usr/bin/putty -load /home/pi/.putty/sessions/132x40 -telnet -P 21264 localhost"

wboerhout avatar Nov 14 '20 09:11 wboerhout

I'm having trouble reproducing this, with the same command parameters:

afbeelding

I did get a segfault in the IDE controller related to threading but that doesn't seem to be this issue.

RaymiiOrg avatar Nov 14 '20 12:11 RaymiiOrg

Just a coincidence then. I keep getting a segfault in Flash.cpp. Will investigate further and open an issue if it persists Thank you for your efforts with this emulator!

wboerhout avatar Nov 14 '20 12:11 wboerhout

This is a stack of the segfault:

std::thread::get_id thread:173
CAliM1543C_ide::run AliM1543C_ide.cpp:2470
CAliM1543C_ide::start_threads()::$_0::operator()() const AliM1543C_ide.cpp:445
std::__invoke_impl<void, CAliM1543C_ide::start_threads()::$_0>(std::__invoke_other, CAliM1543C_ide::start_threads()::$_0&&) invoke.h:60
std::__invoke<CAliM1543C_ide::start_threads()::$_0>(CAliM1543C_ide::start_threads()::$_0&&) invoke.h:95
std::thread::_Invoker<std::tuple<CAliM1543C_ide::start_threads()::$_0> >::_M_invoke<0ul>(std::_Index_tuple<0ul>) thread:244
std::thread::_Invoker<std::tuple<CAliM1543C_ide::start_threads()::$_0> >::operator()() thread:251
std::thread::_State_impl<std::thread::_Invoker<std::tuple<CAliM1543C_ide::start_threads()::$_0> > >::_M_run() thread:195
<unknown> 0x00007f65e688bd84
start_thread 0x00007f65e6bc3609
clone 0x00007f65e6579103

thrController[0] is a nullptr, so i;ll push a fix for that as well. It happens on any telnet connection for me, even without spaces in action or with an empty `action

Do you have a stacktrace maybe or your full es40.cfg or a screenshot?

RaymiiOrg avatar Nov 14 '20 12:11 RaymiiOrg

The command for the serial console program doesn't allow parameters with spaces (quotes don't work).

@lenticularis39 do you have a command to reproduce it with? I'd be happy to look into it further.

RaymiiOrg avatar Nov 14 '20 12:11 RaymiiOrg

see separate issue I just created

wboerhout avatar Nov 14 '20 14:11 wboerhout