lkpy icon indicating copy to clipboard operation
lkpy copied to clipboard

Add LightFM bridge

Open mdekstrand opened this issue 5 years ago • 4 comments

We should add a bridge to LightFM.

mdekstrand avatar Sep 23 '20 14:09 mdekstrand

I've patched together a bridge to LightFM for my own projects and would be happy to try and take this on if you're open to a contribution.

reppertj avatar Dec 16 '20 16:12 reppertj

@reppertj I would love a contribution!

You can look at the tests for the Implicit and HPFrec integrations for an example of the kind of testing we've been doing for the integrations so far. I see lightfm is in conda-forge, so there shouldn't be any problems adding it to the CI infra - just add another Extra to setup.cfg with the LightFM dep, and it should get picked up in the CI builds.

mdekstrand avatar Dec 18 '20 21:12 mdekstrand

@mdekstrand That sounds great! I'll take a crack over the holidays and look to the Implicit and HPFrec integrations as examples as appropriate for the API and testing.

I noticed issue #80 -- ideally, I'd expose LightFM.fit_partial in a way consistent with the planned API there, so let me know if you have any thoughts about how you want to do it.

reppertj avatar Dec 19 '20 13:12 reppertj

@reppertj For LensKIt 0.14, I have started spinning bridges into their own packages, for example https://github.com/lenskit/lenskit-tf. I think this design is the future of a LightFM bridge as well. I keep the issues here, though, to close them once we've added a link to the appropriate spin-off package to the documentation.

mdekstrand avatar Jan 24 '22 18:01 mdekstrand