stream-reactor-dockers icon indicating copy to clipboard operation
stream-reactor-dockers copied to clipboard

Published 20 hours ago • verified publisher icon lensesio

Liveness test doesn't fail when rest service is not running

Open t-d-d opened this issue 6 years ago • 1 comments

The liveness probe is not always failing when it should, specifically when the service seems to be totally down. I think below line should also check for the curl command having failed, e.g. add || [ $? != 0 ]

https://github.com/Landoop/dockers/blob/93f36ff9fb9fcac64fa1038f1cfa48effbcdc7bd/kafka-connect/liveliness.sh#L18

(Also, currently line 24 and 33 syntax error in this case, which doesn't cause a probe failure. Should really be using [[ ]] ?)

t-d-d avatar Mar 12 '18 04:03 t-d-d

@t-d-d thanks. We will be revamping the images soon. Do you mind submitting a PR?

andrewstevenson avatar Mar 12 '18 09:03 andrewstevenson