lens icon indicating copy to clipboard operation
lens copied to clipboard

Clean up versioning and packageJson uses

Open Nokel81 opened this issue 1 year ago • 3 comments

  • Rename packageJsonInjectable -> applicationInformationInjectable

  • Add injectables for all sub items

  • Introduce storeMigrationVersionInjectable for BaseStores

  • Introduce extensionApiVersionInjectable

  • Use buildVersionInjectable in more places, such as in telemetry

Signed-off-by: Sebastian Malton [email protected]

This work is required to make sure we use buildVersionInjectable in all the correct places. I also took the opportunity to clean up the rest of our uses of packageJsonInjectable and to only use a global override.

Nokel81 avatar Sep 07 '22 13:09 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 08 '22 10:09 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Sep 08 '22 12:09 github-actions[bot]

Shout for smaller commits :)

Iku-turso avatar Sep 12 '22 10:09 Iku-turso