lens
lens copied to clipboard
Fix KubeObjectDetails drawer not working for Cluster scoped resources
-
Fix not displaying spinner while object is not defined
-
Fix not displaying loading error if object is not defined
Signed-off-by: Sebastian Malton [email protected]
fixes https://github.com/lensapp/lens/issues/5917 fixes https://github.com/lensapp/lens/issues/5903 fixes https://github.com/lensapp/lens/issues/5936
@jim-docker The fix is in Kube object store.
The rest of the changes are there is make the component not empty when it fails. They were what I did to figure out what the error was. I would consider them big fixes and not just refactorings.
@jim-docker The fix is in Kube object store.
The rest of the changes are there is make the component not empty when it fails. They were what I did to figure out what the error was. I would consider them big fixes and not just refactorings.
Ok, but wasn't there already code to make sure the component was not empty (isLoading
, loadingError
)?
Ok, but wasn't there already code to make sure the component was not empty (isLoading, loadingError)?
Yes but they were only being called if this.object
was already defined which is why in practice the drawer was blank.
Ok, but wasn't there already code to make sure the component was not empty (isLoading, loadingError)?
Yes but they were only being called if
this.object
was already defined which is why in practice the drawer was blank.
So that was the bug fix