lens icon indicating copy to clipboard operation
lens copied to clipboard

Fix KubeObjectDetails drawer not working for Cluster scoped resources

Open Nokel81 opened this issue 1 year ago • 3 comments

  • Fix not displaying spinner while object is not defined

  • Fix not displaying loading error if object is not defined

Signed-off-by: Sebastian Malton [email protected]

fixes https://github.com/lensapp/lens/issues/5917 fixes https://github.com/lensapp/lens/issues/5903 fixes https://github.com/lensapp/lens/issues/5936

Nokel81 avatar Jul 29 '22 13:07 Nokel81

@jim-docker The fix is in Kube object store.

The rest of the changes are there is make the component not empty when it fails. They were what I did to figure out what the error was. I would consider them big fixes and not just refactorings.

Nokel81 avatar Jul 29 '22 16:07 Nokel81

@jim-docker The fix is in Kube object store.

The rest of the changes are there is make the component not empty when it fails. They were what I did to figure out what the error was. I would consider them big fixes and not just refactorings.

Ok, but wasn't there already code to make sure the component was not empty (isLoading, loadingError)?

jim-docker avatar Jul 29 '22 16:07 jim-docker

Ok, but wasn't there already code to make sure the component was not empty (isLoading, loadingError)?

Yes but they were only being called if this.object was already defined which is why in practice the drawer was blank.

Nokel81 avatar Jul 29 '22 18:07 Nokel81

Ok, but wasn't there already code to make sure the component was not empty (isLoading, loadingError)?

Yes but they were only being called if this.object was already defined which is why in practice the drawer was blank.

So that was the bug fix

jim-docker avatar Aug 02 '22 16:08 jim-docker