lens icon indicating copy to clipboard operation
lens copied to clipboard

Fix AddRoleDialog's create button being enabled before entering data

Open Nokel81 opened this issue 1 year ago • 12 comments

Signed-off-by: Sebastian Malton [email protected]

fixes https://github.com/lensapp/lens/issues/5898

Nokel81 avatar Jul 26 '22 13:07 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 28 '22 20:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 28 '22 20:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 02 '22 14:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 04 '22 14:08 github-actions[bot]

This looks rather big for a patch release...

jim-docker avatar Aug 04 '22 19:08 jim-docker

@jim-docker I don't think so, the vast majority of the lines changed are within the snapshots.

Nokel81 avatar Aug 04 '22 19:08 Nokel81

@jim-docker I don't think so, the vast majority of the lines changed are within the snapshots.

I filtered out the snapshots first

jim-docker avatar Aug 04 '22 19:08 jim-docker

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 16 '22 12:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 16 '22 19:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Dec 01 '22 14:12 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Dec 01 '22 14:12 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jan 09 '23 21:01 github-actions[bot]