lens icon indicating copy to clipboard operation
lens copied to clipboard

Published 20 hours ago • verified publisher icon lensapp

Fix kubeconfig-sync sometimes producing multiple identical entities

Open Nokel81 opened this issue 1 year ago • 6 comments

  • This happens when there is an overlapping sync of a folder and a file within that folder both producing the same entities

  • This also fixes the LED not showing up on some KubernetesCluster instances because of this duplication the connected status was being set on the first instance, but renderer would use the second (because JS's Map constructor deduplicates its constructor initializer by taking the last)

  • Added some tests to cover this case

Signed-off-by: Sebastian Malton [email protected]

Nokel81 avatar Jul 19 '22 21:07 Nokel81

This is a big refactor for the 5.6.0 milestone...

jim-docker avatar Jul 20 '22 23:07 jim-docker

We can push this to the next milestone

Nokel81 avatar Jul 21 '22 01:07 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 26 '22 12:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 26 '22 15:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 27 '22 15:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 28 '22 19:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 11 '22 13:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 11 '22 14:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 12 '22 12:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 12 '22 12:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Aug 16 '22 12:08 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 18 '22 15:08 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 15 '22 21:09 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Oct 03 '22 12:10 github-actions[bot]