lens icon indicating copy to clipboard operation
lens copied to clipboard

Readd space between key and value within ContainerEnv

Open Nokel81 opened this issue 2 years ago • 3 comments

  • Add some snapshot tests

Signed-off-by: Sebastian Malton [email protected]

NOTES:

  • Noticed that https://github.com/lensapp/lens/pull/4201 is messing up with the space that was reintroduced in this PR so it is not possible to triple click just the value. I am inclined to close #5588 and instead remove the code and reintroduce #4121 in some form.

Nokel81 avatar Jun 16 '22 13:06 Nokel81

@jansav So is this good enough to merge?

Nokel81 avatar Jun 23 '22 19:06 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 04 '22 20:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 05 '22 18:07 github-actions[bot]

@aleksfront It was changed to = because that is what unix uses to denote env vars everywhere

As for the additional space between the name and the = that wasn't asked for since I didn't bother adding it.

Nokel81 avatar Aug 02 '22 14:08 Nokel81

@aleksfront It was changed to = because that is what unix uses to denote env vars everywhere

As for the additional space between the name and the = that wasn't asked for since I didn't bother adding it.

That's how kubectl shows environment info (using semicolon): kubectl env

aleksfront avatar Sep 01 '22 10:09 aleksfront

Yeah I will have to solve the the conflicts after this is merged

Nokel81 avatar Sep 01 '22 14:09 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Sep 02 '22 17:09 github-actions[bot]