lens
lens copied to clipboard
Readd space between key and value within ContainerEnv
- Add some snapshot tests
Signed-off-by: Sebastian Malton [email protected]
NOTES:
- Noticed that https://github.com/lensapp/lens/pull/4201 is messing up with the space that was reintroduced in this PR so it is not possible to triple click just the value. I am inclined to close #5588 and instead remove the code and reintroduce #4121 in some form.
@jansav So is this good enough to merge?
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
@aleksfront It was changed to =
because that is what unix uses to denote env vars everywhere
As for the additional space between the name and the =
that wasn't asked for since I didn't bother adding it.
@aleksfront It was changed to
=
because that is what unix uses to denote env vars everywhereAs for the additional space between the name and the
=
that wasn't asked for since I didn't bother adding it.
That's how kubectl
shows environment info (using semicolon):
Yeah I will have to solve the the conflicts after this is merged
This pull request has conflicts, please resolve those before we can evaluate the pull request.