lens icon indicating copy to clipboard operation
lens copied to clipboard

Published 20 hours ago • verified publisher icon lensapp

Fix CPU spike when opening PodDetails from MonacoEditor

Open Nokel81 opened this issue 2 years ago • 3 comments

  • Don't mount the children of DrawerParamToggler when closed (default)

Signed-off-by: Sebastian Malton [email protected]

fixes https://github.com/lensapp/lens/issues/5154

Nokel81 avatar Jun 15 '22 13:06 Nokel81

@Nokel81 Just noticed that the issue https://github.com/lensapp/lens/issues/5659 is only presented in current PR.

aleksfront avatar Jun 17 '22 06:06 aleksfront

Thanks will take a look. Might do the fix in a follow up PR

Nokel81 avatar Jun 17 '22 11:06 Nokel81

@aleksfront I found the issue, it was because PodDetailsTolerations were adding to the styles of the DrawerParamToggler which then failed because I converted it to modules. So I have reverted away from modules and we can fix that later.

Nokel81 avatar Jun 17 '22 15:06 Nokel81