lens
lens copied to clipboard
lensapp
Refactor shell sessions injectables
Signed-off-by: Sebastian Malton [email protected]
~Blocked on #5399~
- This work fixes some of the types related to the communication channels
- Converts the IPC request channel for shell authentication to be injectable
- Simplify the local and node shell injectables to be functions all the way down.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conflicts have been resolved. A maintainer will review the pull request shortly.
More effort would be appreciated for why and how refactoring is happening :)
More effort would be appreciated for why and how refactoring is happening :)
Fleshed out the description a bit.
This PR adds features in orbit of fairly new code that holds a higher standard for unit-testing. Regrettably, these new features are not unit tested, hurting this higher standard. Aspirationally, all new features (or even changes in existing features) would come with unit tests, with inclination to behavioural ones.
To be sure, in majority of current scenarios, there are no existing unit tests leading to where a new feature would like to be added. From this disadvantage, it will be a mark of a true craftsman, and a champion of the codebase, to also add these missing tests.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.