lens
lens copied to clipboard
Upgrade to electron@^19
Signed-off-by: Sebastian Malton [email protected]
blocked on https://github.com/lensapp/lenscloud-lens-extension/issues/1660
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
Electron 15 and 16 have reached end-of-life and are no longer supported. This cannot be merged as the <webview>
's used by the extension API currently cannot open windows.
They should be removed entirely.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Conflicts have been resolved. A maintainer will review the pull request shortly.
This pull request has conflicts, please resolve those before we can evaluate the pull request.
Any updates?
@ixrock Yeah I will get back to fixing this PR up. It is currently blocked on removing webview usages in some of the bundled extensions first.
Conflicts have been resolved. A maintainer will review the pull request shortly.
Upvoting for upgrade. Bumped into some other bugs which will be fixed from electron 16.
"@types/node": "^16.14.2"
seems wrong, the latest version on npm is 16.11.49
, and what actually installed in this PR is 16.11.34
(according to lockfile)