lens icon indicating copy to clipboard operation
lens copied to clipboard

Upgrade to electron@^19

Open Nokel81 opened this issue 2 years ago • 18 comments

Signed-off-by: Sebastian Malton [email protected]

blocked on https://github.com/lensapp/lenscloud-lens-extension/issues/1660

Nokel81 avatar May 11 '22 16:05 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar May 16 '22 11:05 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jun 13 '22 15:06 github-actions[bot]

Electron 15 and 16 have reached end-of-life and are no longer supported. This cannot be merged as the <webview>'s used by the extension API currently cannot open windows.

They should be removed entirely.

Nokel81 avatar Jun 13 '22 15:06 Nokel81

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 13 '22 18:06 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jun 13 '22 18:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 14 '22 16:06 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jun 14 '22 16:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 15 '22 20:06 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jun 16 '22 12:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jun 24 '22 12:06 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jun 24 '22 18:06 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 04 '22 20:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 05 '22 18:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 18 '22 17:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 18 '22 18:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 20 '22 05:07 github-actions[bot]

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Jul 20 '22 13:07 github-actions[bot]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions[bot] avatar Jul 22 '22 19:07 github-actions[bot]

Any updates?

ixrock avatar Aug 02 '22 16:08 ixrock

@ixrock Yeah I will get back to fixing this PR up. It is currently blocked on removing webview usages in some of the bundled extensions first.

Nokel81 avatar Aug 02 '22 16:08 Nokel81

Conflicts have been resolved. A maintainer will review the pull request shortly.

github-actions[bot] avatar Aug 05 '22 18:08 github-actions[bot]

Upvoting for upgrade. Bumped into some other bugs which will be fixed from electron 16.

aleksfront avatar Aug 09 '22 07:08 aleksfront

"@types/node": "^16.14.2" seems wrong, the latest version on npm is 16.11.49, and what actually installed in this PR is 16.11.34 (according to lockfile)

chenhunghan avatar Aug 16 '22 05:08 chenhunghan