lomse icon indicating copy to clipboard operation
lomse copied to clipboard

Tenuto bug?

Open HotdogFighter opened this issue 2 years ago • 3 comments

Lomse version: 0.30.0 (master branch, not the release from Sep 11, 2022)

System: Windows 10 (64-bit)

Issue description: I’m new to sheet music (and music in general lol) so I wasn’t sure if this was a stylistic choice or a bug. The tenuto symbol is engraved at different locations compared to MuseScore. They sit above the staff instead of above the note:

tenuto bug report

Steps to reproduce: Compiled with Mingw-W64 on Windows Modified the tutorial 1 file for Windows by loading a preexisting mxl.

Minimal reproduction project:

Tenuto_bug_report.zip

Lomse is an awesome library, thanks for releasing it!

HotdogFighter avatar Jun 19 '23 20:06 HotdogFighter

Thanks for reporting. Properly placing the articulation symbols is complex when there are many notes (e.g.chords) and, currently, lomse does not does not cover all these complexity. But, certainly, in scores such as the submitted sample, it would be better to place the tenuto line as MuseScores does. I will review this and create a PR, but could take a while.

cecilios avatar Jun 20 '23 08:06 cecilios

I've been reading through the source code over the past two months and want to see if I can implement a fix. Will send a PR by the end of August 🚂

HotdogFighter avatar Aug 10 '23 13:08 HotdogFighter

Thank you. I was looking at the bug when you reported it, but properly solving it (and other possible bad cases) require to study many cases with different combinations and to extract some rules, and I have not found yet time for this. Probably, a simpler fix for cases such as the one you reported can be easily implemented. All you have to do is to modify file lomse_articulation_engraver.cpp. I'll be glad if you can prepare a PR.

cecilios avatar Aug 11 '23 10:08 cecilios