Lenin Jaganathan
Lenin Jaganathan
@shakuzen / @jonatan-ivanov Circling back to see if this can be looked upon?
@shakuzen I just went over it again but, If my understanding is right what @brharrington might not be straightforward implementation in a micrometer. Some, of this, is due to the...
The easiest thing I can think of is it just reduces the additional rollCount() call for every recording. Assuming we record 1M times per minute cumulatively on StepCounter we are...
I thought about it for the moment preparing payload and sending them later but that might be a memory-inefficient solution depending on registries because it almost guarantees that we'll hold...
@marcingrzejszczak Was there any discussion on this? It is also unclear if we should allow adding of meterfilters after then registry is initialized/created. The reason is that any meters that...
@shakuzen / @jonatan-ivanov I believe adding meterfilters should be immutable or at the least should not be modified after a meter is registered. Adding meterfilters to the registry once meters...
@shakuzen Just to add to what @tsegismont added initially. We also do the same sort of thing in our internal framework where we are forced to keep a cache to...
@shakuzen Do you want me to address anything more on this PR?
Putting this in draft mode. Will close this PR in a week. For additional info see the linked issue for why this fix might not be desired.
Fixed by https://github.com/micrometer-metrics/micrometer/pull/3750