coveralls-ruby
coveralls-ruby copied to clipboard
feat: add support for JenkinsX
Signed-off-by: ankitm123 [email protected]
Hi @ankitm123. Thanks for this. Did you say these changes support PR builds only? Or both "pull_request" and "push" builds? A full coveralls integration would cover both builds, since "push" builds on the default branch are required to provide PR comments on "pull_request" builds.
What made me think of this was the PR-specific commit sha var here: https://github.com/lemurheavy/coveralls-ruby/pull/171/files#diff-5ff5a04567b99043365ef39f569b3f047a487a20f6a87b7b3b39846ac15325c9R116
I understand we may not have a "push" test in our spec. I'm only seeing one for a "pull_request" build, which is the full scenario, where commit_sha
is always present (as a generic commit sha env var) and service_pull_request
is typically the pull request number from github.
Were you able to get this working for a Coveralls repo? If so, can you share the Coveralls URL so I can review further? Thanks!
Were you able to get this working for a Coveralls repo? If so, can you share the Coveralls URL so I can review further?
yes, but it's a private repo. I can share it via email.
Did you say these changes support PR builds only
Yes, but I have it working for both pull request and master builds. I will change the PR to set values specific to PR and push builds. Do you have an example from another CI providet that I can look at? I will make the changes ...
This issue has been automatically marked for closure because it has not had recent activity. It will be closed if no further activity occurs. If your issue is still active please add a comment and we’ll review as soon as we can. Thank you for your contributions.