reader icon indicating copy to clipboard operation
reader copied to clipboard

Enhancement #317 mark-as-read-backfill

Open Sakunam opened this issue 1 year ago • 4 comments

https://github.com/lemon24/reader/issues/317

I did the first way you suggested.

Sakunam avatar Apr 25 '24 23:04 Sakunam

Codecov Report

Attention: Patch coverage is 97.77778% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.90%. Comparing base (25a7207) to head (8701067).

Files Patch % Lines
src/reader/plugins/mark_as_read.py 92.85% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #333      +/-   ##
==========================================
- Coverage   95.16%   91.90%   -3.26%     
==========================================
  Files          95       95              
  Lines       11611    11656      +45     
  Branches     2179     1539     -640     
==========================================
- Hits        11050    10713     -337     
- Misses        478      875     +397     
+ Partials       83       68      -15     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Apr 26 '24 11:04 codecov[bot]

I think something's wrong with /src/reader/_storage/_sqlite_units.py, I ran the type checking with mypy for my commits and the main branch and I get the same three errors.

Sakunam avatar Apr 26 '24 12:04 Sakunam

Hi, I'm currently away from a computer. I'll be able to take a closer look at this starting with Wednesday.

Re: typing failures: This is likely caused by a new version of mypy being released, feel free to ignore it (IIRC plugins are excluded from type checking).

lemon24 avatar Apr 29 '24 08:04 lemon24

Re: typing failures: This is likely caused by a new version of mypy being released, feel free to ignore it (IIRC plugins are excluded from type checking).

mypy issue fixed in https://github.com/lemon24/reader/commit/ccf010c598dc02cf8a493abbd27bd6babddde464, rebasing on top of latest should fix it here too.

lemon24 avatar May 01 '24 09:05 lemon24

Sorry I took so long, I was on international travel and it took me some time to figure out the changes. Let me know if there's anything wrong. I'm not entirely sure what's going on with the make.bat

Sakunam avatar May 23 '24 10:05 Sakunam

Sorry I took so long, I was on international travel and it took me some time to figure out the changes. Let me know if there's anything wrong. I'm not entirely sure what's going on with the make.bat

No worries, thank you for looking into it. Will be back soon with another commit fix the coverage and the make.bat issue.

lemon24 avatar May 23 '24 19:05 lemon24

Sounds good, thanks for everything!

Sakunam avatar May 24 '24 17:05 Sakunam