ESP32-BLE-Gamepad icon indicating copy to clipboard operation
ESP32-BLE-Gamepad copied to clipboard

[Feature Request] Branch per BLE stack?

Open LeeNX opened this issue 2 years ago • 3 comments

Maybe more a suggestion that a feature request, possible to keep both NimBLE and Bluedroid branches on github? I see that NimBLE is in place, but using zip archives files for the Bluedroid stack in issues, must add unneeded overhead for the developer. Switching between branches locally should be easy, thou I am no git guru.

LeeNX avatar Oct 23 '22 07:10 LeeNX

Yeah - was going to do that, but ran out of time/motivation last holidays after making an updated Bluedroid version for a few people who were chasing it

lemmingDev avatar Oct 23 '22 08:10 lemmingDev

I was poking at the T-vK/ESP32-BLE-Keyboard and saw that it supports both libs with #if defines, like - https://github.com/T-vK/ESP32-BLE-Keyboard/blob/f8dd4852113a722a6b8dc8af987e94cf84d73ad5/BleKeyboard.cpp#L3.

I was thinking possibly three branchs, like main that supports both with the define and two cleaner branchs for each lib. It's a bit more work, but gives us all three options.

See what I can hack up, soon.

LeeNX avatar Jul 06 '23 08:07 LeeNX

Interesting

Any help appreciated!

lemmingDev avatar Jul 06 '23 23:07 lemmingDev