fast_double_parser

fast_double_parser copied to clipboard

fast_double_parser.h polluts global namespace with macros

2

`fast_double_parser.h` does not properly `undefine` macros that it uses locally. https://github.com/lemire/fast_double_parser/blob/master/include/fast_double_parser.h#L71-L115 ``` WARN_UNUSED really_inline unlikely ``` These are pretty common, in other projects, and could have different semantics. They should...

baryluk

Consider tightening FASTFLOAT_ETC_POWER range

1

`include/fast_double_parser.h` says: #define FASTFLOAT_SMALLEST_POWER -325 #define FASTFLOAT_LARGEST_POWER 308 and later, in the `compute_float_64` function: if (unlikely((real_exponent < 1) || (real_exponent > 2046))) { *success = false; return 0; } If...

nigeltao