Daniel Lemire
Daniel Lemire
@j-joker This seems to be a valid issue. I think we should round-up to the word size (64 bits on a 64-bit machine and 32 bits on a 32-bit machine)....
(I am repeating this comment from the PR to make sure it does not get lost:) Please merge the following commit https://github.com/lemire/externalsortinginjava/commit/a5886f7e94b930b0cea260d26b41d412a28cc81c and run `mvn test` before and after your...
This remains unresolved, we may underestimate the memory usage. Some analysis is needed.
Could you contribute a PR?
@joehei Thanks for the PR. It seems to break our tests... Presumably the issue is that it breaks backward compatibility with Java 8. Many users are going to stick with...
The code in place checks that the UTF-16 words represent digits. Your proposed solution checks for the presence of byte values with the high-bit set. Are you assuming that the...
Can you elaborate?
This is now a PR on our main branch, to be merged once people are happy.
You can call the Test functions on all bits, irrespective of its index. Please elaborate. Providing a code sample would be a good way to communicate your issue.
Your issue is valid and easily implemented. I have re-titled it.