Daniel Lemire comments

Results 1862 comments of


                                            Daniel Lemire

object::find_all: find multiple keys in one go

Note that this PR is deliberately left open so we can review it. I plan to test it further soon. If we can make it work, I think we should!

object::find_all: find multiple keys in one go

@the-moisrex Just a ping: *do not assume* that this PR is dead or anything such thing. I am deliberately leaving it is here because it is so important that I...

object::find_all: find multiple keys in one go

@the-moisrex Yes. I also want to make sure that we can use the opportunity to improve the performance.

object::find_all: find multiple keys in one go

@the-moisrex I did some work. There is a minor issue that I could fix easily: we would want 'find_all' to work on `simdjson_result` as well as on `simdjson_result` instances and...

object::find_all: find multiple keys in one go

@the-moisrex I invited you to a private repository where I wrote a benchmark based on this PR. If you get around to it, it would be great if you could...

object::find_all: find multiple keys in one go

@the-moisrex Can we close this in favour of https://github.com/simdjson/simdjson/pull/2247?

object::find_all: find multiple keys in one go

@the-moisrex > The error message: (...) Can you give me a reproducible case? The reference to `cxxopts::exceptions::option_has_no_value` has been in the project for a long time.

BitmapBatchIterator.hasNext() - incorrect result

Thanks. Let us document the behavior. https://github.com/RoaringBitmap/RoaringBitmap/pull/731

BitmapBatchIterator.hasNext() - incorrect result

@shikharid Pull request invited.

src: replace splitstring with built-in

@anonrig The log indicates that GCC 10 is used (which is the default in SmartOS as far as I can tell). However, Node requires g++ 12.2.0 or clang++ 8.0.0 or...