Daniel Lemire comments

Results 1863 comments of


                                            Daniel Lemire

Recover from Parsing Errors and Continue JSON Processing With Ondemand Parser

> this can cause the program to crash It should not crash... not if you are handling the errors or catching the exceptions.

Recover from Parsing Errors and Continue JSON Processing With Ondemand Parser

> Sorry, maybe my previous description was not clear. My example code indeed crashes Once you have encountered an error in the JSON content, you can catch the exception and...

haswell: faster UTF-32 to UTF-16

@WojciechMula Is this a PR we should merge?

Provide UTF-8 to wchar_t (UTF16/32) conversion methods

If you'd like to add functions to our API supporting `wchar_t`, then please prepare a pull request... I believe that it could serve the Windows users so that they do...

Test `issue_convert_valid_utf32_to_latin1_2104d5a31440e3ed` shows inconsistency in implementations

> I'm not sure if this should be tested. Input is not valid Latin1, thus according to the spec the behavior is unspecified. Right. I don't think we want to...

Test `issue_convert_valid_utf32_to_latin1_2104d5a31440e3ed` shows inconsistency in implementations

I am removing the test in patch 7.0.1 https://github.com/simdutf/simdutf/pull/780

add std::span support (optional, C++20)

> I took a stab at this one - converted one function and will see if it passes CI. Do we build for C++20 in CI? :-/

add std::span support (optional, C++20)

> I don't know, but it would definitely be good regardless of this issue or not. Let me check.

add std::span support (optional, C++20)

We do... https://github.com/simdutf/simdutf/blob/8ef144087f72c9c0e536fbd54b666cd1ef80fbe3/.github/workflows/vs17-ci-cxx20.yml#L1

add utf8_length_from_utf16_with_replacement and utf16_length_from_utf8_with_replacement functions

@anonrig That might be ok but it will require a major version since we would be changing the function signature.