Daniel Lemire

Results 1863 comments of Daniel Lemire

I am marking this PR as 'work needed'. Before we adopt this, we need some more analysis.

@richardstartin Do you want to take this one?

That's reasonable, but it would be best to have a use case. I am not sure that generalizing code that is only used in a specific manner is necessarily helpful.

@kf-vikas Can you give me an example of code where you'd use this function? My concern is that your PR adds functionality that is not used, not tested, not benchmarked....

@kf-vikas Let me elaborate on my concern. As @richardstartin stated, this is not part of the public API. This means, in particular, that it could change or disappear in a...

Adding a test would help a lot.

I think that this issue remains to be resolved. We never got a pull request. :-(

@larsk-db is correct... what you are probably looking for are memory-mapped bitmaps.

@sladyn98 Good! Look at how we compute the cardinality. Computing the number of containers is similar/simpler.