FastPFor icon indicating copy to clipboard operation
FastPFor copied to clipboard

Friendly build system for integrating into larger projects.

Open emaxerrno opened this issue 6 years ago • 1 comments

Was looking at adding this and realized that the headers are not scoped to say

include/fpfor/*

for example


#include "common.h"
#include "codecs.h"
#include "vsencoding.h"
#include "util.h"
#include "simple16.h"
#include "simple9.h"
#include "simple9_rle.h"
#include "simple8b.h"
#include "simple8b_rle.h"
#include "newpfor.h"
#include "simdnewpfor.h"
#include "optpfor.h"
#include "simdoptpfor.h"
#include "fastpfor.h"
#include "simdfastpfor.h"
#include "variablebyte.h"
#include "compositecodec.h"
#include "blockpacking.h"
#include "pfor.h"
#include "simdpfor.h"
#include "pfor2008.h"
#include "VarIntG8IU.h"
#include "simdbinarypacking.h"
#include "snappydelta.h"
#include "varintgb.h"
#include "simdvariablebyte.h"
#include "streamvariablebyte.h"
#include "simdgroupsimple.h"


Are you OK with me submitting a change to

  1. CMake
  2. include fixes to the files which is largely cosmetic ?

Would you rather do it ?

At it's core it plays nice to say

  cmake -DCMAKE_BUILD_TYPE=Release \ 
      -DCMAKE_CXX_FLAGS="-O3 -fPIC" \
      -DCMAKE_INSTALL_PREFIX:PATH='{{third_party_dir}}' \

for example (took from my proj)

It makes it easy to integrate w/ other projects.

thoughts ?

emaxerrno avatar Feb 17 '18 18:02 emaxerrno

Sure, please issue a PR.

lemire avatar Feb 17 '18 21:02 lemire