simple-oauth2 icon indicating copy to clipboard operation
simple-oauth2 copied to clipboard

ship typings with npm package

Open Uzlopak opened this issue 2 years ago • 4 comments

Fixes #435

Uzlopak avatar Jun 29 '23 22:06 Uzlopak

Shouldn't the wreck options be imported from that module rather than duplicated here?

voxpelli avatar Aug 26 '23 10:08 voxpelli

@hapi/wreck ships with its typings.

Uzlopak avatar Aug 26 '23 11:08 Uzlopak

@hapi/wreck ships with its typings.

My bad, I remembered it as if @types/simple-oauth2 were referencing @hapi/wreck's types, but I see not that they didn't.

Still – since this module has @hapi/wreck as a dependency, a distinct advantage over @types/simple-oauth2 would be to make use of those types then :)

voxpelli avatar Aug 26 '23 12:08 voxpelli

Hey @Uzlopak thanks for these changes. I am not well versed in typescript typings, so I am inclined to merge your changes and publish a new major, and then refine if necessary. Any chance you could target these changes against develop?

jonathansamines avatar Jun 18 '24 03:06 jonathansamines