Dirk Lellinger

Results 7 comments of Dirk Lellinger

Hi, thank you for commenting this. I did not confuse height and amplitude. In the provided function, the (primary) height parameter is really the maximum function value, and the amplitude...

OK, then let's implement the standard version. I will include then the two calculated parameters `height` and `position`.

Hi, I just updated this PR. I - added tests (code coverage is not complaining any more) - put the import statement in lineshapes.py on separate lines - improved the...

I used iSort to sort the using statements, so now it passes the tests.

Hi, I consolidated the duplication of the docstring. To the other question about the Wikipedia definition and my implementation: It is simply a numerical thing: Of course I can use...

Hi, what I was really wondering about was why you don't have any tests for the function values in your code? At least I haven't seen any. Would make those...

Please have a look at the implementation of System.Numerics.Complex.Magnitude. If it not affects performance, you can it even call directly in Hypotenuse. Dirk