lektor-website icon indicating copy to clipboard operation
lektor-website copied to clipboard

Add Lektor Themes list page

Open nixjdm opened this issue 7 years ago • 8 comments

nixjdm avatar Feb 21 '18 19:02 nixjdm

I imagine another top-level tab on the site similar to https://www.getlektor.com/showcase/, just as I added for /plugins. I (or someone else) could definitely write another plugin just for getlektor.com that pulls in data from https://github.com/lektor/lektor-themes on build to populate pages. I did something similar to build the pages for the plugins, where I pull data from PyPI's public JSON API to build plugin pages. https://github.com/lektor/lektor-website/tree/master/packages/project-data

I had this in mind when I wrote in the lektor-themes readme that screenshots should be placed in the /images dir in the theme repos, hoping that we could pull in those images during build time programmatically.

nixjdm avatar Sep 20 '18 16:09 nixjdm

I could probably do this if no one else wants to :smile:

Andrew-Shay avatar Sep 20 '18 21:09 Andrew-Shay

Great! go ahead @Andrew-Shay

goanpeca avatar Sep 20 '18 21:09 goanpeca

Thanks @Andrew-Shay! And so you don't have to search for it too much, the way to enable the new base page would be to uncomment this: https://github.com/lektor/lektor-website/blob/master/databags/menu.ini#L17-L19

nixjdm avatar Sep 20 '18 21:09 nixjdm

Side note: the way the /plugins pages are built currently, they query PyPI on every build. Preferably this is improved to save / cache the data to not query PyPI on successive builds. It doesn't matter for the deployed build on Travis-CI, but all of those calls add up and make builds slow in development. It would be great if only the first build in development was slow. Bonus points if you can do something similar for the /themes pages. :)

nixjdm avatar Sep 20 '18 21:09 nixjdm

This feature is just about finished. It's based off the Showcase template for consistency. Just waiting on https://github.com/lektor/lektor/issues/599 to make the final changes.

Andrew-Shay avatar Sep 25 '18 23:09 Andrew-Shay

@Andrew-Shay, unblocked? @https://github.com/lektor/lektor/issues/599#issuecomment-426060404

nixjdm avatar Oct 01 '18 20:10 nixjdm

@nixjdm I think so

Andrew-Shay avatar Oct 02 '18 23:10 Andrew-Shay