edr icon indicating copy to clipboard operation
edr copied to clipboard
verified publisher icon lekeno

Take advantage of the latest EDMCOverlay (installable)

Open lekeno opened this issue 7 years ago • 10 comments

Instead of distributing a copy with EDR:

  • [ ] Update documentation to point folks to EDMCOverlay's MSI
  • [x] Update EDR to take advantage of the canonical EDMCOverlay
  • [x] Verify what happens when updating EDR (i.e. plugin specific EDMCOverlay present). Do things work?
  • [ ] Tell EDR users to upgrade EDMCOverlay if they still have the one that was included with EDR, keep things working though.
  • [x] When EDMCOVerlay is missing, use EDR's status line to guide folks (e.g. message + link to latest release)
  • [ ] Needs an updated release for canonical EDMCOverlay (with the send_shape method).

lekeno avatar May 02 '18 07:05 lekeno

Aiming at the next update to v0.8.x

lekeno avatar May 04 '18 02:05 lekeno

There is some weird issue with the canonical overlay (seems to exit repeatedly and get started multiple times)

I also need a version with shape support in the python helper.

Hmm, maybe not ready for 0.8.2

lekeno avatar Jun 07 '18 03:06 lekeno

Hmm odd, the new build doesn't actually have any code changes. But occasionally directx or nvidia updates have made it unstable.

inorton avatar Jun 07 '18 05:06 inorton 

EDMCOverlay exe found: [...]\AppData\Local\EDMarketConnector\plugins\EDMCOverlay\EDMCOverlay.exe...
EDMCOverlay is starting 

[...]\AppData\Local\EDMarketConnector\plugins\EDMCOverlay\EDMCOverlay.exe

error in ensure_service: [...]\AppData\Local\EDMarketConnector\plugins\EDMCOverlay\EDMCOverlay.exe exited"

Is the type of error I see frequently and repeatedly. @inorton any idea?

lekeno avatar Jun 11 '18 03:06 lekeno

Can you find me your edmcoverlay.log file?

inorton avatar Jun 11 '18 07:06 inorton

Burned 0.8.3 for a hotfix so 0.8.4, hopefully. @inorton I found it but it only had a few "connection forcibly closed" errors. I'll try to repro again and see if there is anything different.

lekeno avatar Jun 12 '18 11:06 lekeno

I see this error sometimes: "error in ensure_service: local variable 'program' referenced before assignment"

@inorton

lekeno avatar Jun 18 '18 10:06 lekeno

When closing EDMC, I'm also seeing this (probably minor):

error in send_raw: 'NoneType' object has no attribute 'send'
Traceback (most recent call last):
  File "plug.pyo", line 227, in notify_stop
  File "[...]\EDMarketConnector\plugins\EDMCOverlay\load.py", line 64, in plugin_stop
  File "[...]\EDMarketConnector\plugins\EDMCOverlay\edmcoverlay.py", line 109, in send_raw
AttributeError: 'NoneType' object has no attribute 'send'

lekeno avatar Jun 20 '18 03:06 lekeno

I'm still blocked on the weird issues above but more importantly the canonical EDMCOverlay should include the send_shape method since EDR relies on it.

lekeno avatar Jun 25 '18 03:06 lekeno

I'm getting "error in ensure_service" when EDMC tries to run EDMCOverlay, which exits without starting.

Running the latest version of EDR 1.00

Anyone know how to resolve this error?

incryptx avatar Nov 09 '19 21:11 incryptx