lejunyang

Results 11 comments of lejunyang

我现在用的是idea 2019.2 跟这有关系吗

I think we could have a `formAssociated` option in `defineCustomElement`, and add that static prop in `VueCustomElement` ```js static formAssociated = !!Comp.formAssociated ``` `ElementInternals` should be attached if we want...

I tested with below patch for [email protected]: ```text diff --git a/dist/client/app/router.js b/dist/client/app/router.js index 3deaefe382586bdff92597fd8daf85b14bbc4f73..bb046ddf64b0a542ecda715c9453442830159f51 100644 --- a/dist/client/app/router.js +++ b/dist/client/app/router.js @@ -46,6 +46,7 @@ export function createRouter(loadPageModule, fallbackComponent) { if (!comp)...

@edison1105 Thanks for your suggestions! It's a good fix for current issues. However I found another issue regarding moving element. If we move a child element directly into other element(not...

Actually setting `_resolved` to false can cause some duplicate executions, like `_applyStyles`

Oh, I forgot to run e2e tests in my local, my bad. I can see it's from `_parseSlots`, child custom element is removed and unmounted... let me see how to...

The reason `work with Teleport (shadowRoot: false)` test case fails is that: `my-y` is defined first, `my-p` is defined later, and it removes `my-y` and causes unmounting. I think this...

Updated, thanks for the info Also I was correct, `this._resolved = false` will lead to `applyStyle` twice. `unmount` doesn't remove style nodes so we don't need to `applyStyle` again. I...

Should we also create a new API like useHostInternals()? As _internal seems to be a private field