ha-google-home icon indicating copy to clipboard operation
ha-google-home copied to clipboard

Published 20 hours ago • verified publisher icon leikoilja

Bluetooth sensor integrated, showing the nearest Bluetooth device

Open ChrisAllen1982 opened this issue 2 years ago • 1 comments

ChrisAllen1982 avatar Aug 16 '22 18:08 ChrisAllen1982

Please fix the CLI first 😃

DurgNomis-drol avatar Aug 23 '22 15:08 DurgNomis-drol

Created https://github.com/ChrisAllen1982/ha-google-home/pull/1 to @ChrisAllen1982's branch to correct the issues blocking this PR.

marcusds avatar Sep 26 '22 19:09 marcusds

I've noticed I am not seeing the sensor.*_bt_devices sensor anywhere. I haven't had a chance to dig into why yet.

marcusds avatar Sep 26 '22 20:09 marcusds

This is probably why.

Logger: homeassistant.components.sensor
Source: custom_components/google_home/sensor.py:91
Integration: Sensor (documentation, issues)
First occurred: 1:26:50 PM (1 occurrences)
Last logged: 1:26:50 PM

Error while setting up google_home platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 281, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/google_home/sensor.py", line 91, in async_setup_entry
    device.device_model,
AttributeError: 'GoogleHomeDevice' object has no attribute 'device_model'

marcusds avatar Sep 26 '22 20:09 marcusds

One of my previous fixes used the wrong property: https://github.com/ChrisAllen1982/ha-google-home/pull/2

marcusds avatar Sep 26 '22 21:09 marcusds

https://github.com/ChrisAllen1982/ha-google-home/pull/4 Fix the final linting errors, not sure why running it locally didn't flag these issues.

marcusds avatar Sep 27 '22 16:09 marcusds

@DurgNomis-drol

Please fix the CLI first 😃

I think this is ready for review now?

marcusds avatar Sep 28 '22 19:09 marcusds

I'm relatively new to the GitHub workflow. Do I need to assign the pr to someone to review?

ChrisAllen1982 avatar Sep 28 '22 20:09 ChrisAllen1982

Generally someone will grab it.

marcusds avatar Sep 28 '22 20:09 marcusds

@ChrisAllen1982, @HarvsG, @marcusds, guys, is anyone of you have any availability these days - feel free to grab this PR and move it further. We need to fix the requested changes and re-request review :)

leikoilja avatar Oct 11 '22 06:10 leikoilja

Hi!

Great idea! Is there any progress on this? I would really like this feature.

Greetings, Jos

josvink66 avatar Nov 15 '22 11:11 josvink66

Closing for lack of activity :( hopefully it will be picked up at some point down the road :)

leikoilja avatar Sep 20 '23 12:09 leikoilja

Any news about this? It's a few years now and still a missing basic feature.

Leatherface75 avatar Jun 05 '24 20:06 Leatherface75