wice_grid icon indicating copy to clipboard operation
wice_grid copied to clipboard

Get rid of Kaminari

Open leikind opened this issue 10 years ago • 4 comments

Implement pagination inside the plugin. Ain't no rocket science.

leikind avatar Aug 10 '14 11:08 leikind

I think it would be better to leave the choice to the user. We are already using kaminari in our project and we want to have one code for the pagination. For this reason, it would be helpful to have a config option to specify the kaminari theme, to switch to the default (or other custom theme), instead of the wice_grid one.

afdev82 avatar Feb 26 '16 09:02 afdev82

I will refer you to (1) this http://www.mikeperham.com/2016/02/09/kill-your-dependencies/, (2) this https://github.com/amatsuda/kaminari/pull/267 (3) and this ugly hack https://github.com/leikind/wice_grid/blob/rails3/lib/wice/kaminari_monkey_patching.rb

If WiceGrid does pagination by itself, what do you care? You just continue using Kaminari.

Having said that, I am not going to do this. I am tired of supporting this project for more than 6 years (https://www.mail-archive.com/[email protected]/msg44536.html) and I am looking for other maintainers.

leikind avatar Feb 26 '16 09:02 leikind

I read the provided links. I agree with them. My issue was only not to have the theme for the pagination hardcoded, but to have an option to opt-out and choose another theme instead of the wice_grid one.

afdev82 avatar Feb 26 '16 10:02 afdev82

if i did this I'd leave the markup the same

leikind avatar Feb 26 '16 10:02 leikind