Leigh
Leigh
Could you link to some validations that would change and be replaced with the new state function?
I think the first four spots you linked to make sense and look like good candidates for that. The last spot less so because the guard is checking an authorized...
One of the lines noted in the output is a call to `t.Logf`, so maybe it's a bad idea for us to be calling that function inside the go routine....
I think we need to re-evaluate whether we want to tackle withdrawal functionality now as part of milestone 1a. Withdrawal feels like an important feature. I think it should be...
> I'd like to defer implementing withdraw and revisit the design at some point in the future, rather than implementing it now. > > @acharb @nikhilsaraf @accordeiro @tomerweller Thoughts? I'm...
Reopened but will keep out of a milestone.
An alternative to consider here is to not suggest using proptest for now, and then only come back to recommending it if we find a way to improve it. Proptest...
Looks like there are still situations where the upgrade can fail, such as if the file needs updating due to an xdr change, and the image can keep running.
I've seen it a couple times, intermittent, not consistent. On other PRs rerunning the build resulted in a pass. I kicked it again.
@chadoh brought up separately today about the need for some work @BlaineHeffron did recently to be able to configure the minimum TTL for a quickstart. I think that use case...