mdl-ext icon indicating copy to clipboard operation
mdl-ext copied to clipboard

lightboard: semantically incorrect use of markup

Open leifoolsen opened this issue 9 years ago • 0 comments

This:

<ul class="mdlext-lightboard mdlext-js-lightboard">
  <li class="mdlext-lightboard__slide">
    <a href="#" class="mdlext-lightboard__slide__frame">
      <figure>
        <img src="_D802591.jpg" title="Whooper swans in flight"/>
        <figcaption>_D802591.jpg</figcaption>
      </figure>
    </a>  
  <li>
</ul>

The markup should not have a required anchor element. It should be optional. Something like this:

<ul class="mdlext-lightboard mdlext-js-lightboard">
  <li class="mdlext-lightboard__slide">
    <figure role="group">
      <a href="/images/_D802591-large.jpg">
        <img src="/images/_D802591.jpg" alt="View a larger version of this image"/>
      </a>
      <figcaption>Whooper swans in flight</figcaption>
    </figure>
  <li>
</ul>

leifoolsen avatar Aug 31 '16 10:08 leifoolsen