Leif Johansson comments

Results 36 comments of


                                            Leif Johansson

Discovery hints from IdP:s delivering orgAffiliation

Note that this discussion is covered extensively in the seamlessaccess working groups on discovery hinting. The issue we are facing is exactly the same one that is faced by big...

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

Can you provide a sample URL that breaks?

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

Also feel free to provide a PR for quicker review but that URL would make a good testcase...

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

yeah this smells URL encoding fail to me somewhere - normally that == would/should have been URL-encoded before passing to pyFF because otherwize you could never do query-string parsing

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

Yeah you're right. I need to think about the right way to deal with this. Your patch at least solves one part of this so I don't mind applying it...

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

Is it still there in the wsgi api? Skickat från min iPhone > 26 aug. 2019 kl. 14:38 skrev Martin : > > From time to time we're trying to...

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

if it is still in HEAD I'd appreciate a PR!

store.py match("^(.+)=(.+)$", key) lookup breaks entityID's with base64 encoded, padded content

ping @mrvanes what should we do about this?

invalid MDQ response when entityID ends with .xml

I believe this was fixed with the content negotiation policy feature yes?

it should be possible to have pyff stop a pipline unless all load statements succeed

Thinking about how to implement this in the load pipeline it looks like it will be quite involved because of the complex error handling in that function. My thought is...