Jürg Lehni comments

Results 192 comments of


                                            Jürg Lehni

Security Fix for Prototype Pollution in v1

The referenced function has since been changed to use `isSafeKey()`, which checks for `__proto__`. This PR thus doesn't need merging anymore.

Security Fix for Prototype Pollution in v1

Actually, the fix was already in place before the PR was submitted, and thus the PR was never needed nor did it change anything: https://github.com/Vincit/objection.js/commit/867dc46537a8536578556e4b25b2add411f2a5e5 @koskimas was quite clear on...

Static methods not exposed on Model Type

I'd be happy to review a PR adding these typings

Static methods not exposed on Model Type

Closed by #2612

A problem with typescript version 4

I managed to reproduce the endless recursion on v3.0.2 on the test-case provided by @stefanvanherwijnen [here](https://github.com/Vincit/objection.js/issues/2132#issuecomment-962988859). I can confirm that the fix from @Linksku as summarized [here](https://github.com/Vincit/objection.js/issues/2132#issuecomment-1007384618) does indeed fix...

Question: How to handle parent -> grandchild relationships?

The question appears to have been answered, closing.

[question] can I get ref to this row?

Closing in the absence of a response

added error for relatedQueries ommiting 'for' outside subqueries

@kibertoad I think we should merge this. What's your take on this?

Can't add or modify a value during $beforeUpdate using upsertGraph

This appears to have been fixed. But due to the rounding and low multipliers in your example, the values still often end up being the same. With this adjusted example...

Can't add or modify a value during $beforeUpdate using upsertGraph

Ok I understand it now. I am looking into a fix.